Smart Weld Evaluation

Discussion in 'Garry's Mod: Flood' started by Donkie, Jan 10, 2016.

  1. Donkie

    Donkie Founder & Senior Developer Platinum VIP

    Joined:
    Jun 2, 2014
    Messages:
    904
    Likes Received:
    660
    Discord:
    Donkie#2878
    Few months back, I added distance-restriction to the smartweld welds. Basically, previously welds would be created all over your boat, criss cross. With my update, only props close to each other will get welded.

    This is pretty neat because:
    • Boats break up realistically, if you destroy the middle part of a snakey boat, it will get split in two. If you create a roof, you need pillars to support the roof, if the pillars get destroyed, the roof falls down.
    • This also solves a issue, sky boats, people literally can't make skyboats using these restrictions.
    • Ultimately, less welds are created. Less welds = Less calculations for server = Less lag.

    I have received very little feedback on this, with the only being Alex complaining about some visual feedback issues with the tool, but also that this actually creates more lag with boats spazzing out because they're too "unstable".

    This restriction isn't applied to the regular weld tool yet because it's an experiment.

    The question is, should we call the experiment a feature, declare it complete and apply it to the weld tool too? Or should I scrap the distance restriction?
     
    #1
  2. David

    David Dedicated Member Platinum VIP

    Joined:
    Dec 14, 2015
    Messages:
    118
    Likes Received:
    12
    Personally, I LOVE smart weld. It is my savior in terms of anti-lag and quick welding! By the way, I want to talk to you about an infinite money exploit in flood. Add me on steam if possible.
    And about the distance thing ~ I think smart weld is perfect as it is right now.
     
    #2
  3. counter

    counter Godly Member Platinum VIP

    Joined:
    Feb 21, 2015
    Messages:
    3,124
    Likes Received:
    845
    Server:
    Flood
    Discord:
    co#2858
    I think it should apply to weld as well because skyboats like mentioned.
     
    #3
  4. jeffreythe00

    jeffreythe00 Dreamer

    Joined:
    Jun 2, 2014
    Messages:
    1,277
    Likes Received:
    526
    Keep the distance restriction. Theres no legitimate reason you'd ever want to weld something far away other than to exploit the weld tool. If it turns out to be too far then you can adjust it based on player feedback. Alternatively if you want to keep something in a distance close to your main boat (like a backup boat) you can use the rope tool to keep it anchored to the main boat. (Granted this is a VIP feature but a feature nonetheless)

    This weld modification may also solve the issue of shark boats "unintentionally" since those props sometimes can separate in weird ways when flying across the map. It may also create new issues when building.

    Boats breaking up realistically I think is a good thing but not everyone may like it. I personally wouldn't mind it as it adds yet another layer of play-ability to the gamemode.

    Skyboats being gone is a great thing but it was never as huge of an issue as everyone made it out to be other than a few instances where some players were able to exploit this rule for a massive advantage.

    Less welds are a GOOD thing when it comes to server performance as more constraints = more lag. However less welds means you will not be able to weld as effectively. This opens the possibility that people may switch back to the regular weld tool. So I hope these changes apply to that too NOT just the smart weld.

    Other than this being a huge change to the gamemode I really see it as an overall improvement.
     
    #4
  5. Wolfgang

    Wolfgang Veteran Member Platinum VIP

    Joined:
    May 27, 2015
    Messages:
    1,614
    Likes Received:
    778
    Server:
    Flood
    I did see a players boat spas out but was unable to determine the cause. After shooting one of his props his boat seemed to disappear and then I saw it was behind me. He then informed me that it had gone flying across the map.
     
    #5
  6. Decap

    Decap Super Radman

    Joined:
    Jul 9, 2014
    Messages:
    3,049
    Likes Received:
    881
    I like it so far except for the fact that picking up one prop among your boat can cause that prop and others around it to glitch into a bad position because the aren't welded tightly, thus whole boat loosely stays together. The old smart weld tool did not have this issue. All of the props welded stayed together like they were literally welded at the seams. With this new tool, it seems like they were welded at only one spot of the prop and it doesn't hold them together well. Maybe this was intention, maybe not. I do like it otherwise, but sometimes if you pick your boat up to move it, spin it, or flip it, there is a chance one prop will get stuck in a bad position and then your entire boat is screwed.
     
    #6
    • Agree Agree x 1
  7. jeffreythe00

    jeffreythe00 Dreamer

    Joined:
    Jun 2, 2014
    Messages:
    1,277
    Likes Received:
    526
    That is because Donkie removed all of the configuration options for smart weld. He needs to enable the "Freeze props" feature for this NOT to happen. I agree its terrible as it is currently.
     
    #7
  8. Donkie

    Donkie Founder & Senior Developer Platinum VIP

    Joined:
    Jun 2, 2014
    Messages:
    904
    Likes Received:
    660
    Discord:
    Donkie#2878
    How on earth does the freeze props feature fix that? Doesn't people already freeze props in place before welding anyways?
     
    #8
  9. jeffreythe00

    jeffreythe00 Dreamer

    Joined:
    Jun 2, 2014
    Messages:
    1,277
    Likes Received:
    526
    Theres many instances where you weld without freezing props. Re-adding that feature fixes all of the issues.

    • Time is limited, so welding just a few props on to your boat last min can cause your boat to glitch out.
    • When you rebuy. Your boat is already welded but you need to place a few props on to fix it.
    • When you move your boat and put more props on.
    • When your teammates move your boat because its in their way.
     
    #9
  10. Donkie

    Donkie Founder & Senior Developer Platinum VIP

    Joined:
    Jun 2, 2014
    Messages:
    904
    Likes Received:
    660
    Discord:
    Donkie#2878
    I still don't get what you mean, just to be clear, what do you think the freeze function does?
     
    #10
  11. jeffreythe00

    jeffreythe00 Dreamer

    Joined:
    Jun 2, 2014
    Messages:
    1,277
    Likes Received:
    526
    The "freeze function" freezes the props right before the welds are applied. The problem with the smart weld is that it seems to apply a negative weld force to the props. Causing them to buckle or fold ontop of each other if they are not frozen.
     
    #11
  12. [Dick Figures] Blue

    [Dick Figures] Blue Member

    Joined:
    Dec 20, 2015
    Messages:
    1
    Likes Received:
    0
    I have noticed that if you forget to freeze 1 or multiple props when using smart weld they start spazzing out and it ruins your intire round, maybe theirs a fix for that, if i find any more bugs relating to the tool gun i'll report it
     
    #12
  13. jeffreythe00

    jeffreythe00 Dreamer

    Joined:
    Jun 2, 2014
    Messages:
    1,277
    Likes Received:
    526
    unless Donkie enables the feature I mentioned, the only way to stop that from happening is to freeze all your props before you weld.
     
    #13
  14. Donkie

    Donkie Founder & Senior Developer Platinum VIP

    Joined:
    Jun 2, 2014
    Messages:
    904
    Likes Received:
    660
    Discord:
    Donkie#2878
    I could make the smartweld freeze then unfreeze the props. You won't notice any difference but it won't glitch.
     
    #14
  15. Decap

    Decap Super Radman

    Joined:
    Jul 9, 2014
    Messages:
    3,049
    Likes Received:
    881
    That wont help bc the props glitch when you are moving your boat not when you are welding.
     
    #15
  16. jeffreythe00

    jeffreythe00 Dreamer

    Joined:
    Jun 2, 2014
    Messages:
    1,277
    Likes Received:
    526
    This is a whole other issue than the one I thought you were talking about. The reason the smart weld prevented this from happening in the past is because it would no-collide all the props with all the other props. Therefore preventing the welds from slipping/streching, causing your boat to get deformed when moving it.
     
    #16
  17. Wolfgang

    Wolfgang Veteran Member Platinum VIP

    Joined:
    May 27, 2015
    Messages:
    1,614
    Likes Received:
    778
    Server:
    Flood
    Played the other day and realized this whole thing fucks up my favorite boat. Can we make it just so it stops sky-boats and none of the other stuff?
     
    #17
  18. Donkie

    Donkie Founder & Senior Developer Platinum VIP

    Joined:
    Jun 2, 2014
    Messages:
    904
    Likes Received:
    660
    Discord:
    Donkie#2878
    how would it only stop skyboats?
     
    #18
    • Agree Agree x 1
  19. Wolfgang

    Wolfgang Veteran Member Platinum VIP

    Joined:
    May 27, 2015
    Messages:
    1,614
    Likes Received:
    778
    Server:
    Flood
    Make it so that you can't weld props that aren't touching eachother. Not the other shit.
     
    #19
  20. Donkie

    Donkie Founder & Senior Developer Platinum VIP

    Joined:
    Jun 2, 2014
    Messages:
    904
    Likes Received:
    660
    Discord:
    Donkie#2878
    That's the only thing this change does?
     
    #20